feat(hydroflow_plus)!: strongly-typed runtime cluster IDs #1477
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying hydroflow with
|
| Latest commit: |
74e602a
|
| Status: | ⚡️ Build in progress... |
shadaj
force-pushed
the
pr1477
branch
5 times, most recently
from
4ff704c
to
008ca9b
Compare
davidchuyaya
approved these changes
Oct 4, 2024
MingweiSamuel
approved these changes
Oct 7, 2024
This was referenced Oct 7, 2024
Instead of `u32`s everywhere, we now have a `ClusterId<C>` type that ensures that cluster IDs are not misused.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of
u32s everywhere, we now have aClusterId<C>type that ensures that cluster IDs are not misused.Stack created with Sapling. Best reviewed with ReviewStack.